Ballu #329
Ballu #329
Conversation
Add: components_lib for me
Update: FetGate class so it can switch out the switch Add: directional switch power button
Update: PCB to be routed
Update: FetPowerGate to have btn_in Update: Ballu to use the lib version of FetPowerGate with center as a power switch
There was a problem hiding this comment.
I see this adds an example and adds the soft power button to the core library (instead of just in the multimeter example, as it was before). For that, can you:
- deduplicate with the multimeter example, and refactor the multimeter example to use the core library
- update comments on the schematic about how it's supposed to be used
- add a description into the class docstring describing how it's supposed to be used, and that users should be careful not to connect the button to any downstream circuit, and that it's not checked
- maybe a better name - SoftPowerGate? I think these are typically called soft power switches, but this subcircuit has the button / switch external.
- would be preferable (but not required) if the library change was separate from the example
Will look over the example circuit hdl and layout momentarily.
There was a problem hiding this comment.
I skimmed the HDL and layout and it looks reasonable for fabrication. Hopefully it works!
One suggestion is to silkscreen label the connectors, so it's obvious which is for what.
Were you also going to try to add the reverse protected charger circuit? I think as of now nothing is reverse protected?
You could also consider using a copper pour for the inner power layer, then have higher priority pours to make sub-sections (like for battery voltage, if your main pour is 3v3).
However, if you want to merge the full example into the main codebase, we need to have a longer discussion on style and form - the examples should be examples of best practices, style, and structure. In any case, I think it makes sense to merge the FetPowerGate (see prior comment) as a standalone library improvement.
As an alternative to merging this example, it might be possible to create your own repository and submodule PolymorphicBlocks - allowing you to keep your own repository of convenience Blocks that might not be as generalizable as the current library blocks. There might need to be some IDE changes to make this work, we can also discuss that.
|
@ducky64 Thanks for the review!
We plan to make many more of this board with more tweaks, so the reverse protection will be added later... |
|
migrated into #334 |
Add: SoftPowerGate and switch Originally from #329 --------- Co-authored-by: Richard Lin <[email protected]>
Update: FetPowerSwitch with btn_in
Add: The BALLU PCB board uses FetPowerSwitch with a directional switch center as the power button.
TODO: manufacture