Add descriptions support for the nodes: ExampleTable, Outline and Sce… #254
Conversation
|
This looks great! How does it change the output of the pretty printer in Behat, though? As long as it's just that the descriptions are cleanly omitted I think that's fine? |
| @@ -437,6 +438,7 @@ protected function parseOutline() | |||
| $token = $this->expectTokenType('Outline'); | |||
|
|
|||
| $title = trim($token['value'] ?? ''); | |||
There was a problem hiding this comment.
why removing the trimming for scenario but not for outline ?
There was a problem hiding this comment.
I thought to make it compatible with the CompatibilityTest for the descriptions.feature.
I now see this is NOT the case. I will fix this.
There was a problem hiding this comment.
Reverted the trim scenario title functionality.
|
This might impact the pretty printer ignoring description because previously, that description would be parsed as a multi-line title (and so displayed). |
|
I didn't check that, but as this change is not backwards compatible based on functionality a new major version should be released including this feature. |
Now the
descriptions.featuresample in CompatibilityTest will work.The code is backward compatible.