Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movement refactor #8474

Closed
wants to merge 5 commits into from
Closed

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Feb 10, 2023

Ports /tg/:

Ports:

About The Pull Request

Mostly backend fixes. Turns a lot of movement code (which was in massive procs) into signals. Code improvement and performance stuff is the primary focus here.

Mostly effects:

  • stuff that check or effect what position the player-character is in(buckled, lying on the floor, standing up)
  • bodypart disabling in its entirety basically
  • health states (unconscious, soft crit...)
  • stuff that checks the state of limbs (either being handcuffed, disabled, or amputated)

I also converted a bunch of overused redefines stuff into setters.

Why It's Good For The Game

Clears out a lot of code debt. Should make movement a lot more performant(which is definitely a goal if we want to transition to smooth movement eventually), and should also fix janky movement shit at higher server loads.

Code is a lot more legible, too. The whole mobility_flags thing was CBT to try and code with in a previous pr of mine, so this is a bit personal.

This PR contributes to:

Testing Photographs and Procedure

Screenshots&Videos

mangled
Flew off a two floor drop, limb disabling seems to work as expected.

blindness
Blindness performs as expected

Changelog

🆑 RKz, dwasint
refactor: basically all the limb disabling system
refactor: made a bunch of movement-related code signal-based instead of /proc/
code: carbon body position checks
code: made a bunch of overused redefines into setters
/:cl:

@Tsar-Salat
Copy link
Contributor Author

To note, I left most of dwasint's blindness stuff out, because Racc is already doing that in #8204

@PowerfulBacon PowerfulBacon added the Test Merged This PR is currently in rotation label Feb 25, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor Author

Tsar-Salat commented Feb 26, 2023

DNM until #8204 (or testmerge, bacon)

Mobility and status effects of this PR rely on blindness improvements of that one.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat Tsar-Salat marked this pull request as draft March 12, 2023 17:21
@itsmeow itsmeow removed the Test Merged This PR is currently in rotation label Mar 15, 2023
@Tsar-Salat
Copy link
Contributor Author

physphoza has a while to go, some im going to kick this off the open prs for now

@Tsar-Salat Tsar-Salat closed this Mar 16, 2023
@Tsar-Salat Tsar-Salat mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants