-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtle messages balloon alert #11870
base: master
Are you sure you want to change the base?
Conversation
great change, could you add this functionality to headset messages? you send them through the player panel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to apply to telekinetic messages, and why not show the message? If you are showing it in balloon chat people are going to be confused when they see "you see a voice in your head" and there's no actual message other than hidden away in the chat where you are diverting their attention away from
Its supposed to be a indicator to divert your attention to the chat. Most people will get the hint of the balloon alert and go to check the chat box imo. I thought telekinesis already did that but i'll add it now. |
At least for admin stuff, this way is much better because we usually use spans in those anyways. |
The only reason is to actually make people look at them anyway. You wouldn't need the ratvar span if the message appeared directly to the user |
Also, you cant look back on balloon alerts. Maybe an admin sent you the nuke codes for example but you dont remember them because it appeared in a balloon alert. |
Good point actually. If we want custom themed messages we can always use the narrates anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not display full message as a baloon instead? It should wrap anyway
Look back on the previous conversation |
Just display the message both as baloon and in chat. What's the issue with that? |
You shouldn't know where that message comes from. |
About The Pull Request
Subtle messages (AND HEADSET MESSAGES) appear with a balloon alert saying "You hear a voice in your head.." now
Why It's Good For The Game
Subtle messages are very hard to miss, people aren't always looking at the bottom right of their screen, the balloon alert will get people to look at the bottom of their screen then see the real message.
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.2024-11-10.17-09-04.mp4
2024-11-10.20-07-05.mp4
Changelog
🆑
tweak: Subtle messages, telepathy, and headset messages now show a balloon alert
/:cl: