Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtle messages balloon alert #11870

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Therealdoooc213
Copy link
Contributor

@Therealdoooc213 Therealdoooc213 commented Nov 10, 2024

About The Pull Request

Subtle messages (AND HEADSET MESSAGES) appear with a balloon alert saying "You hear a voice in your head.." now

Why It's Good For The Game

Subtle messages are very hard to miss, people aren't always looking at the bottom right of their screen, the balloon alert will get people to look at the bottom of their screen then see the real message.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

2024-11-10.17-09-04.mp4
2024-11-10.20-07-05.mp4

Changelog

🆑
tweak: Subtle messages, telepathy, and headset messages now show a balloon alert
/:cl:

@Marshmellow105
Copy link

great change, could you add this functionality to headset messages? you send them through the player panel.

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to apply to telekinetic messages, and why not show the message? If you are showing it in balloon chat people are going to be confused when they see "you see a voice in your head" and there's no actual message other than hidden away in the chat where you are diverting their attention away from

@Therealdoooc213
Copy link
Contributor Author

This also needs to apply to telekinetic messages, and why not show the message? If you are showing it in balloon chat people are going to be confused when they see "you see a voice in your head" and there's no actual message other than hidden away in the chat where you are diverting their attention away from

Its supposed to be a indicator to divert your attention to the chat. Most people will get the hint of the balloon alert and go to check the chat box imo. I thought telekinesis already did that but i'll add it now.

@TsunamiAnt
Copy link
Contributor

why not show the message?

At least for admin stuff, this way is much better because we usually use spans in those anyways.

@PowerfulBacon
Copy link
Member

The only reason is to actually make people look at them anyway. You wouldn't need the ratvar span if the message appeared directly to the user

@Therealdoooc213
Copy link
Contributor Author

Also, you cant look back on balloon alerts. Maybe an admin sent you the nuke codes for example but you dont remember them because it appeared in a balloon alert.

@TsunamiAnt
Copy link
Contributor

Good point actually. If we want custom themed messages we can always use the narrates anyways.

Copy link
Member

@Archanial Archanial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not display full message as a baloon instead? It should wrap anyway

code/modules/admin/verbs/randomverbs.dm Outdated Show resolved Hide resolved
@Therealdoooc213
Copy link
Contributor Author

Why not display full message as a baloon instead? It should wrap anyway

Look back on the previous conversation

@Archanial
Copy link
Member

Just display the message both as baloon and in chat. What's the issue with that?
The idea of chatmessages is that you don't look at the chat.

@EvilDragonfiend
Copy link
Member

Just display the message both as baloon and in chat. What's the issue with that? The idea of chatmessages is that you don't look at the chat.

You shouldn't know where that message comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants