Modernises cameras: Automatic mapping of network and phasing out the auto_name subtype #11485
Conversation
PowerfulBacon
changed the title
PowerfulBacon
changed the title
…eir areas assigned
Challenge accepted! jkjk |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| // Calculate the camera tag | ||
| if (!c_tag) | ||
| c_tag = "[format_text(camera_area.name)] #[++autonames_in_areas[camera_area]]" | ||
| network = camera_area.camera_networks |
There was a problem hiding this comment.
shouldn't it be Copy()?
There was a problem hiding this comment.
The list in theory should be readonly so can be a reference, but I'll add vv edit protections to stop admins fucking things up
| if (!c_tag) | ||
| c_tag = "[format_text(camera_area.name)] #[++autonames_in_areas[camera_area]]" |
There was a problem hiding this comment.
| if (!c_tag) | |
| c_tag = "[format_text(camera_area.name)] #[++autonames_in_areas[camera_area]]" | |
| if (!c_tag) | |
| if (istype(camera_area, /area/space)) | |
| c_tag = "[format_text(camera_area.name)] #[++autonames_in_areas[camera_area]] (Space)" | |
| else | |
| c_tag = "[format_text(camera_area.name)] #[++autonames_in_areas[camera_area]]" |
this will be nice if we can notice a camera is located at space or not.
There was a problem hiding this comment.
This code will only ever append space if the connected wall is space, in which case it will just say "space #1 (space)". What you want is a check to see if the current turf is space but the area is not, which I can add (will append external on in that case)
There was a problem hiding this comment.
yeah you're right. some cameras that are only intended to show spaces are hard to recognise when the names are the same.
|
I do not see any particularly wrong on the codes. prolly fine. |
fixes #11484
Try breaking my cameras now mappers!
About The Pull Request
If a camera is in space, it will use the area of the thing it is attached to.
To be compliant with this PR, run the update path script, mapping changes have been done entirely through updatepaths alone.
Regex for finding modified sec consoles:
Since away missions are going to be removed anyway, I'm not bothering to properly update them and just removing the consoles from them.
Why It's Good For The Game
With almost every mapping change, cameras and their networks become broken. It is pointless to sit on this system that just isn't working when we could do a much better job with them being calculated from the area instead.
Most of the manual attempts at creating camera networks haven't even been done properly.
Testing Photographs and Procedure
Testing Evidence
Syndicate shivs work and are per-shuttle rather than global. I have no idea how but they do work
Changelog
🆑
tweak: Tweaks camera naming and networks to be automatically assigned rather than mapped.
/:cl: