Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose ExpressionField, use __slots__ for several class #1038

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

expose ExpressionField, use __slots__ for several class #1038

wants to merge 4 commits into from

Conversation

CAPITAINMARVEL
Copy link
Contributor

No description provided.

@CAPITAINMARVEL CAPITAINMARVEL changed the title add ExpressionField at beanie __init__, and __slots__ in beanie fields class add ExpressionField at beanie __init__, and optimisation using __slots__ Oct 6, 2024
@CAPITAINMARVEL
Copy link
Contributor Author

i forget it triger action every commit

@CAPITAINMARVEL
Copy link
Contributor Author

Thoughts ?

@CAPITAINMARVEL CAPITAINMARVEL requested a review from a team October 7, 2024 14:59
@CAPITAINMARVEL CAPITAINMARVEL changed the title add ExpressionField at beanie __init__, and optimisation using __slots__ expose ExpressionField at init, and optimisation using __slots__ Oct 7, 2024
@CAPITAINMARVEL CAPITAINMARVEL changed the title expose ExpressionField at init, and optimisation using __slots__ expose ExpressionField, and use __slots__ for several class Oct 8, 2024
@staticxterm
Copy link

I am not so sure about this PR. Could you please write some more additional information, what exactly are we getting with the __slots__ "optimisation"? I feel like we're adding possible further maintenance burden on us by doing so, and also restricting other usages if we introduce __slots__.

@CAPITAINMARVEL
Copy link
Contributor Author

I am not so sure about this PR. Could you please write some more additional information, what exactly are we getting with the __slots__ "optimisation"? I feel like we're adding possible further maintenance burden on us by doing so, and also restricting other usages if we introduce __slots__.

Yeah you right its probably not needed and just restricting perhaps for ExpressionField since its used a lots in beanie when user input Player.money its of instance ExpressionField

Riverfount
Riverfount approved these changes Oct 11, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job. But the GA is not ok, just fix it and it is ok to me.

@CAPITAINMARVEL
Copy link
Contributor Author

Great Job. But the GA is not ok, just fix it and it is ok to me.

GA ?

@CAPITAINMARVEL
Copy link
Contributor Author

Oh the action

@Riverfount
Copy link

Great Job. But the GA is not ok, just fix it and it is ok to me.

GA ?

Github Action lol

@CAPITAINMARVEL CAPITAINMARVEL marked this pull request as ready for review October 11, 2024 17:33
@CAPITAINMARVEL CAPITAINMARVEL changed the title expose ExpressionField, and use __slots__ for several class expose ExpressionField, use __slots__ for several class Oct 11, 2024
@staticxterm
Copy link

I'm sorry, but I still don't get what issue this is trying to solve... Are there any usage examples or benchmarks where this is proven to be faster than it currently is?

Riverfount
Riverfount approved these changes Oct 21, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Riverfount Riverfount Riverfount approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CAPITAINMARVEL @staticxterm @Riverfount