Skip to content

Commit

Permalink
error
Browse files Browse the repository at this point in the history
  • Loading branch information
Baunsgaard committed Oct 21, 2024
1 parent 23730ec commit 7455f8d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,9 @@ private CompressedEncode(MultiColumnEncoder enc, FrameBlock in, int k) {
}

private boolean containsCompressed(FrameBlock in) {
for(Array<?> c : in.getColumns()) {
if(c instanceof ACompressedArray) {
for(Array<?> c : in.getColumns())
if(c instanceof ACompressedArray)
return true;
}
}
return false;
}

Expand Down Expand Up @@ -398,6 +396,7 @@ private AColGroup passThrough(ColumnEncoderComposite c) {

if(a.getValueType() != ValueType.BOOLEAN // if not booleans
&& (stats == null || !stats.shouldCompress || stats.valueType != a.getValueType())) {
// stats.valueType;
double[] vals = (double[]) a.changeType(ValueType.FP64).get();

MatrixBlock col = new MatrixBlock(a.size(), 1, vals);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
import org.apache.sysds.runtime.DMLRuntimeException;
import org.apache.sysds.utils.stats.InfrastructureAnalyzer;

import scala.NotImplementedError;

/**
* This common thread pool provides an abstraction to obtain a shared thread pool.
*
Expand Down Expand Up @@ -121,9 +123,10 @@ else if(mainThread || threadName.contains("PARFOR")) {
return pool; // Return the shared pool for this parfor or main thread.
}
else {
throw new NotImplementedError();
// If we are neither a main thread or parfor thread, allocate a new thread pool
LOG.warn("An instruction allocated it's own thread pool indicating that some task is not properly reusing the threads.");
return Executors.newFixedThreadPool(k);
// LOG.warn("An instruction allocated it's own thread pool indicating that some task is not properly reusing the threads.");
// return Executors.newFixedThreadPool(k);
}

}
Expand Down

0 comments on commit 7455f8d

Please sign in to comment.