forked from apache/systemds
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commit reverts the recent addition of components in the code coverage utility. Unfortunately, the components did more than anticipated, because they add more checks to the commits and were not visible in the PR that was trying their behavior. The intended behavior was to have coverage measurements and easy selection of sub-packages in the codecov webpage (this worked on the PR). Instead, it also added extra unintended 'Actions' that had to be passed for validation once merged to main. Furthermore, the Python upload of code coverage did not work once merged to main, therefore that change is reverted as well.
- Loading branch information
1 parent
bbd79d2
commit 2c7fb4b
Showing
2 changed files
with
3 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,15 +128,15 @@ jobs: | |
export SYSDS_QUIET=1 | ||
export LOG4JPROP=$SYSTEMDS_ROOT/src/test/resources/log4j.properties | ||
cd src/main/python | ||
unittest-parallel -t . -s tests -v --coverage-branch --coverage-xml .coverage.xml --coverage-source systemds | ||
unittest-parallel -t . -s tests -v | ||
# python -m unittest discover -s tests -p 'test_*.py' | ||
echo "Exit Status: " $? | ||
- name: Run all python tests no environment | ||
run: | | ||
export LOG4JPROP=$(pwd)/src/test/resources/log4j.properties | ||
cd src/main/python | ||
unittest-parallel -t . -s tests -v --coverage-branch --coverage-xml .coverage.xml --coverage-source systemds | ||
unittest-parallel -t . -s tests -v | ||
# python -m unittest discover -s tests -p 'test_*.py' | ||
echo "Exit Status: " $? | ||
|
@@ -155,10 +155,4 @@ jobs: | |
run: | | ||
black --check src/main/python/tests | ||
- name: Upload coverage to Codecov | ||
uses: codecov/[email protected] | ||
if: github.repository_owner == 'apache' | ||
env: | ||
fail_ci_if_error: false | ||
files: src/main/python/.coverage.xml | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters