BAH-3034 | Capturing relationships/contacts in patient registration #632
Conversation
…ment app (#608) * modify existing relationships view in registration page * update. httpd conf to serve static files for person management app * update. view of patient relationship section * update UI according to new mockups * update. css to fix alignment issues
…places all the previous relationships (#627)
Screenshots of relationship section catering to addition of both providers through existing input field and person through person management app
|
|
@Arjun-Go Is this feature behind a config which can be toggled on/off based on config ? |
|
Yes, the idea is that if the "Relationship" section is being shown, then this new feature will be available (wherein for provider the old behaviour will continue, and for any other relationship the new Person App pop-up will show). There is no configuration which decides if the Person App should be shown/not. cc: @angshu. |
| @@ -11,3 +13,17 @@ COPY package/docker/style.css /usr/local/apache2/htdocs/ | |||
|
|
|||
| # Copy BahmniApps | |||
| COPY ui/dist/. /usr/local/apache2/htdocs/bahmni/ | |||
|
|
|||
| # Download Person Management App | |||
| RUN <<EOR | |||
There was a problem hiding this comment.
Any particular reason of packaging the person management app like this? We could have just bundled it as another image and/or used from MFE way or even proxy to the container serving the app.
This will also mean that for every build of bahmniapps, we are downloading and packaging person management app.
There was a problem hiding this comment.
+1 here, also this would make versioning difficult, every build/patch fix in person management app would need an commit in bahmniapps also and will need a release of bahmni-web image as well.
| @@ -35,20 +44,25 @@ | |||
| </select> | |||
| </div> | |||
| <span class="asterick showOn-desktop">*</span> | |||
| <!-- <div class="relationship-extension-btn">--> | |||
There was a problem hiding this comment.
if these arent needed, why keep commented code
| ng-click="openPopupWindow(newRelationship)">{{ ::'REGISTRATION_LABEL_SELECT_PERSON' | translate }} | ||
| </button> | ||
| </div> | ||
| <!-- <input type="text" ng-switch-when="patient" bahmni-autocomplete--> |
| ng-change="clearPatient(newRelationship)" on-select="patientSelected(newRelationship)" | ||
| placeholder="{{ ::'REGISTRATION_LABEL_ENTER_NAME_ID' | translate}}" | ||
| ng-class="{'illegalValue': !newRelationship.personB.uuid||duplicateRelationship(newRelationship)}" is-invalid="isInvalidRelation(newRelationship)"/> | ||
| <div class="relationship-extension-btn"> |
There was a problem hiding this comment.
How are the different types of relationship handled?
JIRA link - https://bahmni.atlassian.net/browse/BAH-3034?atlOrigin=eyJpIjoiZTM5YjgxNmRjNjIwNGZhMGE1Y2JiZTM3M2JlMDBhMmUiLCJwIjoiaiJ9
Summary
This PR has the following changes ->
Add Personbutton for each relationship which when clicked would render the iframe to show the person-management-app.Screenshots
Before save
After save