BAH-2647 | Already active Visits not allowed to create again

[atish160384]

• If the visit of same patient at same location already exists then it is not allowed to create visit again.

[gokultw]

Keys are having spaces! it will be good if spaces are replaced by underscore

[gsluthra]

This check has been added in the UI codebase, and not in the backend. I think this is incorrect. The UI codebase is just ONE browser client. Ideally this is domain/business logic, which should be in backend, so that once a visit is started by ANY client, no one else should be able to start a visit for the same visit location. I think this code should be in bahmni-core and not in bahmniapps.

Also, need to validate with @angshu. Locations can have hierarchy. E.g
Apollo Hospital -> OPD Department -> ClinicA, ClinicB, ClinicC
Apollo Hospital -> IPD Department

There is some expectation that one visit can only be started in one sub-tree. But another visit can be started in another sub-tree. For instance the same patient can have parallel visits in OPD and IPD, but only one visit at a time within OPD/IPD.

[gokultw]

We have a different card for Backend fix. https://bahmni.atlassian.net/browse/BAH-1784
We had a discussion with Angshu and decided that we will not fix that. form openmrs it is the expected behaviour to have multiple visits in same location.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ atish3101
❌ atish160384
_{You have signed the CLA already but the status is still pending? Let us recheck it.}