Merge pull request #119 from williamdes/phpstan

Some phpdoc and type fixes
Bacon · Dec 7, 2022 · 3c6b551 · 3c6b551
2 parents fc62b92 + 7f2e94c
commit 3c6b551
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 6 deletions.
diff --git a/src/Common/CharacterSetEci.php b/src/Common/CharacterSetEci.php
@@ -89,6 +89,9 @@ final class CharacterSetEci extends AbstractEnum
      */
     private static $nameToEci;
 
+    /**
+     * @param int[] $values
+     */
     public function __construct(array $values, string ...$otherEncodingNames)
     {
         $this->values = $values;

diff --git a/src/Common/FormatInformation.php b/src/Common/FormatInformation.php
@@ -62,7 +62,7 @@ class FormatInformation
     /**
      * Offset i holds the number of 1 bits in the binary representation of i.
      *
-     * @var array
+     * @var int[]
      */
     private const BITS_SET_IN_HALF_BYTE = [0, 1, 1, 2, 1, 2, 2, 3, 1, 2, 2, 3, 2, 3, 3, 4];
 

diff --git a/src/Common/Mode.php b/src/Common/Mode.php
@@ -42,6 +42,9 @@ final class Mode extends AbstractEnum
      */
     private $bits;
 
+    /**
+     * @param int[] $characterCountBitsForVersions
+     */
     protected function __construct(array $characterCountBitsForVersions, int $bits)
     {
         $this->characterCountBitsForVersions = $characterCountBitsForVersions;

diff --git a/src/Encoder/Encoder.php b/src/Encoder/Encoder.php
@@ -37,7 +37,7 @@ final class Encoder
     /**
      * Codec cache.
      *
-     * @var array
+     * @var array<string,ReedSolomonCodec>
      */
     private static $codecs = [];
 

diff --git a/src/Renderer/Image/SvgImageBackEnd.php b/src/Renderer/Image/SvgImageBackEnd.php
@@ -334,7 +334,7 @@ private function createGradientFill(Gradient $gradient, float $x, float $y, floa
         $this->xmlWriter->writeAttribute('stop-color', $this->getColorString($startColor));
 
         if ($startColor instanceof Alpha) {
-            $this->xmlWriter->writeAttribute('stop-opacity', $startColor->getAlpha());
+            $this->xmlWriter->writeAttribute('stop-opacity', (string) $startColor->getAlpha());
         }
 
         $this->xmlWriter->endElement();
@@ -344,7 +344,7 @@ private function createGradientFill(Gradient $gradient, float $x, float $y, floa
         $this->xmlWriter->writeAttribute('stop-color', $this->getColorString($endColor));
 
         if ($endColor instanceof Alpha) {
-            $this->xmlWriter->writeAttribute('stop-opacity', $endColor->getAlpha());
+            $this->xmlWriter->writeAttribute('stop-opacity', (string) $endColor->getAlpha());
         }
 
         $this->xmlWriter->endElement();

diff --git a/src/Renderer/Module/EdgeIterator/EdgeIterator.php b/src/Renderer/Module/EdgeIterator/EdgeIterator.php
@@ -41,7 +41,7 @@ public function __construct(ByteMatrix $matrix)
     }
 
     /**
-     * @return Edge[]
+     * @return Traversable<Edge>
      */
     public function getIterator() : Traversable
     {

diff --git a/src/Renderer/Path/EllipticArc.php b/src/Renderer/Path/EllipticArc.php
@@ -136,7 +136,7 @@ public function toCurves(float $fromX, float $fromY) : array
     /**
      * @return Curve[]
      */
-    private function createCurves(float $fromX, $fromY) : array
+    private function createCurves(float $fromX, float $fromY) : array
     {
         $xAngle = deg2rad($this->xAxisAngle);
         list($centerX, $centerY, $radiusX, $radiusY, $startAngle, $deltaAngle) =