Merge pull request #15059 from RaananW/oversightsAreTheBest

The disposed engine needs to be the thinengine
BabylonJS · May 3, 2024 · f7a1c3f · f7a1c3f
2 parents 31530f7 + 5ae4771
commit f7a1c3f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/dev/core/src/Misc/dumpTools.ts b/packages/dev/core/src/Misc/dumpTools.ts
@@ -52,8 +52,8 @@ export class DumpTools {
             EngineStore.OnEnginesDisposedObservable.add((e) => {
                 // guaranteed to run when no other instances are left
                 // only dispose if it's not the current engine
-                if (e !== engine && !e.isDisposed) {
-                    e.dispose();
+                if (engine && e !== engine && !engine.isDisposed) {
+                    engine.dispose();
                 }
             });
             engine.getCaps().parallelShaderCompile = undefined;

diff --git a/packages/tools/tests/test/visualization/config.json b/packages/tools/tests/test/visualization/config.json
@@ -787,12 +787,14 @@
         {
             "title": "GLTF Serializer Morph Target Animation Group",
             "playgroundId": "#T087A8#29",
-            "referenceImage": "gltfSerializerMorphTargetAnimationGroup.png"
+            "referenceImage": "gltfSerializerMorphTargetAnimationGroup.png",
+            "excludedEngines": ["webgl1"]
         },
         {
             "title": "GLTF Serializer KHR materials clearcoat",
             "playgroundId": "#9N6CLU#23",
-            "referenceImage": "glTFSerializerKhrMaterialsClearcoat.png"
+            "referenceImage": "glTFSerializerKhrMaterialsClearcoat.png",
+            "excludedEngines": ["webgl1"]
         },
         {
             "title": "GLTF Serializer KHR gpu instancing",