Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
어드민 계정 분리 관련 페이지 작업 #63
base: develop
Are you sure you want to change the base?
어드민 계정 분리 관련 페이지 작업 #63
Changes from 8 commits
a1b281c
379c474
12a226f
4939b2b
e3d56ca
d85c1b8
6f4f08c
3b01170
658b5f9
81e2de8
67d92b1
74127bb
dc6868d
df357a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
antd를 살펴보니 다이나믹룰 이라고 하면서dependencies와 rule의 validation으로 비번 확인에 활용할 수 있는게 있는 것 같아요! 버전 등으로 못쓸 수도 있으니 확인 한번 해주시면 좋을 것 가탕요!
error 관련은 따로 쓰기보다는 antd의 form의 input을 쓰고 있으니 가능하다면 rule안에서 최대한 처리하는 방식을 찾아보는 것도 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependencies
라는 속성이 있었군요! 반영했습니다!! 81e2de8 , 67d92b1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
본인이 하지 않았지만,
ChangePasswordForm
과LoginForm
이 다른 방식으로 validate하는 이유가 있는지 살펴보고, 바꿀 부분이 있다면 고쳐주세요.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useLogout
이 hook으로 분리될 정도로 재사용되나요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SideNav
한 곳에서만 로그아웃을 하기 때문에 재사용성은 없습니다.SideNav
에서 정의해도 될 것 같습니다.반영했습니다! 74127bb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 토큰을 저장하는 용도로
redux
를 사용하고 있는데,redux
를 단순 저장용도로 사용하고 다른 사이드 이펙트를 React쪽에서 관리하는 이유라도 있을까요?