Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NetworkManager into BaseClient #7386

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Refactor NetworkManager into BaseClient #7386

wants to merge 6 commits into from

Conversation

tnorling
Copy link
Collaborator

  • Refactors sole function in NetworkManager into BaseClient consolidating post logic to one place and allowing for direct collection of telemetry before / after the call (more on this in a follow up PR)
  • Moves requestId telemetry collection to right after the network call, ensuring it gets emitted even if an error is thrown later

@github-actions github-actions bot added msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package labels Oct 17, 2024
@github-actions github-actions bot added the documentation Related to documentation. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@trwalke trwalke Awaiting requested review from trwalke trwalke is a code owner

@pmaytak pmaytak Awaiting requested review from pmaytak pmaytak is a code owner

@gladjohn gladjohn Awaiting requested review from gladjohn gladjohn is a code owner

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava neha-bhargava is a code owner

@rayluo rayluo Awaiting requested review from rayluo rayluo is a code owner

@Avery-Dunn Avery-Dunn Awaiting requested review from Avery-Dunn Avery-Dunn is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

@shylasummers shylasummers Awaiting requested review from shylasummers shylasummers is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Related to documentation. msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tnorling