Make clear synchronous in msal-node #7364
Merged
+53
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
msal-node
shylasummers
changed the title
shylasummers
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz,
bgavrilMS,
Robbie-Microsoft,
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo,
Avery-Dunn and
jo-arroyo
as code owners
shylasummers
requested review from
konstantin-msft and
lalimasharda
as code owners
tnorling
approved these changes
Oct 9, 2024
sameerag
approved these changes
Oct 9, 2024
Robbie-Microsoft
approved these changes
Oct 10, 2024
…tion-library-for-js into clearCacheAsync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ClientApplication.clearCache is synchronous even though it calls NodeStorage.clear, an asynchronous function. Since
cleardoes not contain any asynchronous elements, this PR:clearas a synchronous functionasync clearfrom CacheManager (since clear is msal-browser should be kept asynchronous)