PoP Support for Node when brokered #7360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
sameerag,
hectormmg,
peterzenz,
bgavrilMS,
Robbie-Microsoft,
trwalke,
pmaytak,
gladjohn,
neha-bhargava,
rayluo and
Avery-Dunn
as code owners
github-actions
bot
added
documentation
peterzenz
approved these changes
Oct 7, 2024
| @@ -1030,6 +1161,7 @@ if (process.platform === "win32") { | |||
| const result: AuthResult = { | |||
| idToken: "", | |||
| accessToken: "", | |||
| authorizationHeader: "", | |||
There was a problem hiding this comment.
Tons of duplicate code in this PR, can we do anything to eliminate the duplication?
| | Name | Description | Required | | ||
| |-------------------------| ----------------------------------------------------------- | -------- | | ||
| | `authenticationScheme` | Indicates whether MSAL should acquire a `Bearer` or `PoP` token. Default is `Bearer`. | **Required** | | ||
| | `resourceRequestMethod` | The all-caps name of the HTTP method of the request that will use the signed token (`GET`, `POST`, `PUT`, etc.) | **Required** | |
There was a problem hiding this comment.
I'd generally suggest we uppercase the incoming value rather than asking for all-caps input.
sameerag
approved these changes
Oct 7, 2024
…reAD/microsoft-authentication-library-for-js into pop-support-in-node-brokered
tnorling
requested review from
jo-arroyo,
lalimasharda,
konstantin-msft and
shylasummers
as code owners
…tion-library-for-js into pop-support-in-node-brokered
…reAD/microsoft-authentication-library-for-js into pop-support-in-node-brokered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PoP support for Node when using the native broker