Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional example to documentation #7241

Closed
wants to merge 3 commits into from
Closed

Conversation

bvwidt
Copy link
Contributor

@bvwidt bvwidt commented Aug 8, 2024

I have added another example that I find is missing from the documentation in order to implement MSAL for Angular in any project.

@github-actions github-actions bot added documentation Related to documentation. msal-angular Related to @azure/msal-angular package labels Aug 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 27, 2024
@bvwidt
Copy link
Contributor Author

bvwidt commented Aug 27, 2024

Can anyone review this small documentation change (@jo-arroyo, @tnorling or @peterzenz)?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Sep 16, 2024
@jo-arroyo
Copy link
Collaborator

@bvwidt Thank you for your interest in contributing to our library. Unfortunately, the html tags you are looking to add aren't strictly necessary for every application using MSAL Angular. While it is needed for applications using the MsalRedirectComponent, applications using popup or standalone Angular applications won't need them, so we will not be adding it to our initialization doc. Please see our doc on redirects for more details, and we welcome contributions from you in the future.

@jo-arroyo jo-arroyo closed this Oct 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants