Add additional logging for NAA initialization #7064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codexeon
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz and
konstantin-msft
as code owners
sameerag
approved these changes
Apr 30, 2024
codexeon
force-pushed
the
dasau/naa_bridge_logging
branch
from
5a201f9
to
f78051c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional logging for NAA initialization to help diagnose if NestAppAuthController is being used for the session, or if it is falling back to StandardController. Also log exception that occurred in trying to use Nested App Auth bridge to get further details on failure cases. The change also avoids the time spent trying to initialize the bridge if caller does not opt-in to supportsNestedAppAuth.