Expose response handler and update attributes' access modifiers #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
konstantin-msft
commented
Aug 2, 2023
konstantin-msft
commented
- Make ResponseHandler attributes protected for extendability.
- Add optional "clientId" param to generateCacheRecord.
- Expose "CacheRecord" and "ResponseHandler" as part of msal-browser "internals".
konstantin-msft
force-pushed
the
expose_response_handler
branch
from
8982e31
to
f15f496
Compare
github-actions
bot
added
msal-browser
Codecov Report
|
- Add optional "clientId" param to generateCacheRecord. - Expose "CacheRecord" and "ResponseHandler" as part of msal-browser "internals".
konstantin-msft
force-pushed
the
expose_response_handler
branch
from
30d0842
to
bfe94af
Compare
sameerag
reviewed
Aug 7, 2023
| @@ -24,6 +25,7 @@ export { NativeInteractionClient } from "./interaction_client/NativeInteractionC | |||
| export { RedirectHandler } from "./interaction_handler/RedirectHandler"; | |||
| export { EventHandler } from "./event/EventHandler"; | |||
| export { NativeMessageHandler } from "./broker/nativeBroker/NativeMessageHandler"; | |||
| export { ResponseHandler } from "@azure/msal-common"; | |||
There was a problem hiding this comment.
Is this to avoid common exports in the future?
There was a problem hiding this comment.
I don't really want to add new stuff to internals, let's instead focus on what we need to do to remove internals all-up
| private persistencePlugin: ICachePlugin | null; | ||
| private performanceClient?: IPerformanceClient; | ||
| private readonly clientId: string; | ||
| protected readonly cacheStorage: CacheManager; |
There was a problem hiding this comment.
I think we can avoid this with the cache changes made by Thomas.
There was a problem hiding this comment.
Yeah none of this should be needed. I understand this may be a stopgap but all of this will be superseded by the 1P changes and we'll then have to revert all of this again. Would prefer to just hold out until the 1P changes are done
| private performanceClient?: IPerformanceClient; | ||
| private readonly clientId: string; | ||
| protected readonly cacheStorage: CacheManager; | ||
| protected readonly cryptoObj: ICrypto; |
There was a problem hiding this comment.
Same here, if logger and crypto are available. Let us check on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.