Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and run formatting check in CI #6264

Merged
merged 9 commits into from
Jul 28, 2023
Merged

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Jul 26, 2023

Formatting changes cause code churn and make PRs harder to review. This adds a CI check to ensure formatting is correct on each PR and applies formatting to all the files which were missed in the original move to Prettier.

Future enhancement could auto commit a formatting fix, if needed

@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library. msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-react Related to @azure/msal-react extensions Related to extensions for the base libraries labels Jul 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #6264 (201f4e2) into dev (81d34b4) will decrease coverage by 2.11%.
Report is 219 commits behind head on dev.
The diff coverage is 67.42%.

Flag Coverage Δ *Carryforward flag
msal-angular 96.73% <92.78%> (+0.22%) ⬆️
msal-browser 85.60% <ø> (-0.87%) ⬇️ Carriedforward from 686e6f0
msal-common 82.47% <ø> (-2.07%) ⬇️
msal-core ?
msal-node 79.29% <ø> (-4.10%) ⬇️
msal-node-extensions 68.51% <60.77%> (-7.13%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ions/msal-node-extensions/src/utils/Environment.ts 20.51% <0.00%> (-22.08%) ⬇️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
...b/msal-browser/src/app/IPublicClientApplication.ts 43.75% <ø> (ø)
...ib/msal-browser/src/app/PublicClientApplication.ts 66.66% <ø> (-28.67%) ⬇️
...er/src/broker/nativeBroker/NativeMessageHandler.ts 85.83% <ø> (-0.12%) ⬇️
... and 69 more

... and 164 files with indirect coverage changes

@github-actions github-actions bot removed samples Related to the samples apps for the library. extensions Related to extensions for the base libraries labels Jul 26, 2023
@github-actions github-actions bot added the extensions Related to extensions for the base libraries label Jul 26, 2023
Copy link
Contributor

@peterzenz peterzenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you not mixing functional changes with the broad formatting ones.

@tnorling tnorling enabled auto-merge (squash) July 28, 2023 18:59
@tnorling tnorling merged commit c34e759 into dev Jul 28, 2023
33 of 42 checks passed
@tnorling tnorling deleted the formatting-check branch July 28, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Related to extensions for the base libraries msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package msal-react Related to @azure/msal-react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants