Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append v2 to endpoint when using a Microsoft authority under OIDC protocol mode #6256

Merged
merged 21 commits into from
Aug 1, 2023
Merged

Append v2 to endpoint when using a Microsoft authority under OIDC protocol mode #6256

merged 21 commits into from
Aug 1, 2023

Conversation

shylasummers
Copy link
Contributor

@shylasummers shylasummers commented Jul 21, 2023 •
edited
Loading

Currently, MSAL appends v2 to the default open id configuration endpoint only when using AAD protocol mode or when authority type is ADFS. This PR changes that check to append v2 to the endpoint when using a known Microsoft authority or when authority type is ADFS.

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jul 21, 2023
@shylasummers shylasummers changed the title First commit Throw an error when using OIDC mode with a Microsoft authority Jul 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #6256 (9fd5307) into dev (81d34b4) will decrease coverage by 1.97%.
Report is 225 commits behind head on dev.
The diff coverage is 67.42%.

Flag Coverage Δ
msal-angular 96.73% <92.78%> (+0.22%) ⬆️
msal-browser 85.55% <ø> (-0.92%) ⬇️
msal-common 82.91% <ø> (-1.64%) ⬇️
msal-core ?
msal-node 79.29% <ø> (-4.10%) ⬇️
msal-node-extensions 68.51% <60.77%> (-7.13%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Files Changed Coverage Δ
...ions/msal-node-extensions/src/utils/Environment.ts 20.51% <0.00%> (-22.08%) ⬇️
lib/msal-angular/src/msal.interceptor.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.module.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.navigation.client.ts 93.33% <ø> (+0.47%) ⬆️
lib/msal-angular/src/msal.redirect.component.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/packageMetadata.ts 100.00% <ø> (ø)
...b/msal-browser/src/app/IPublicClientApplication.ts 42.42% <ø> (-1.33%) ⬇️
...ib/msal-browser/src/app/PublicClientApplication.ts 67.44% <ø> (-27.89%) ⬇️
...er/src/broker/nativeBroker/NativeMessageHandler.ts 86.29% <ø> (+0.33%) ⬆️
... and 66 more

... and 166 files with indirect coverage changes

hectormmg
hectormmg requested changes Jul 26, 2023
View reviewed changes
lib/msal-browser/src/config/Configuration.ts Outdated Show resolved Hide resolved
lib/msal-common/src/index.ts Outdated Show resolved Hide resolved
@hectormmg hectormmg self-requested a review July 26, 2023 20:36
hectormmg
hectormmg approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@hectormmg hectormmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the msal-browser Related to msal-browser package label Jul 31, 2023
@shylasummers shylasummers changed the title Throw an error when using OIDC mode with a Microsoft authority Append v2 to endpoint when using a Microsoft authority Jul 31, 2023
@shylasummers shylasummers changed the title Append v2 to endpoint when using a Microsoft authority Append v2 to endpoint when using a Microsoft authority under OIDC protocol mode Jul 31, 2023
@shylasummers shylasummers merged commit 8cbd07c into dev Aug 1, 2023
31 of 42 checks passed
@shylasummers shylasummers deleted the oidc-known-authorities branch August 1, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameerag sameerag sameerag left review comments

@lalimasharda lalimasharda lalimasharda left review comments

@hectormmg hectormmg hectormmg approved these changes

@konstantin-msft konstantin-msft konstantin-msft approved these changes

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

Assignees
No one assigned
Labels
msal-common Related to msal-common package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shylasummers @codecov-commenter @hectormmg @tnorling @sameerag @peterzenz @lalimasharda @konstantin-msft