Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize hardcoded metadata over network-sourced metadata #6231

Merged
merged 13 commits into from
Jul 12, 2023

Conversation

hectormmg
Copy link
Member

@hectormmg hectormmg commented Jul 11, 2023

  • Fixes a bug where hardcoded metadata for Cloud Instance Discovery was incorrectly built and therefore never worked
  • Promotes hardcoded Cloud Instance Discovery metadata over cached and network metadata sources
  • Fixes a bug where azure region update method mutates the existing metadata object instead of returning a new object causing MSAL to prepend azure region cumulatively
  • Promotes hardcoded Endpoint metadata over cached and network metadata sources

@github-actions github-actions bot added the msal-common Related to msal-common package label Jul 11, 2023
@github-actions github-actions bot added documentation Related to documentation. msal-node Related to msal-node package msal-browser Related to msal-browser package labels Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #6231 (788daf6) into dev (81d34b4) will decrease coverage by 1.52%.
The diff coverage is 75.57%.

Flag Coverage Δ
msal-angular 96.73% <96.63%> (+0.22%) ⬆️
msal-browser 86.17% <ø> (-0.30%) ⬇️
msal-common 83.30% <ø> (-1.24%) ⬇️
msal-core ?
msal-node 79.39% <ø> (-4.00%) ⬇️
msal-node-extensions 69.29% <60.12%> (-6.35%) ⬇️
msal-react 94.24% <ø> (-0.45%) ⬇️
node-token-validation ?
Impacted Files Coverage Δ
...ions/msal-node-extensions/src/utils/Environment.ts 20.51% <0.00%> (-22.08%) ⬇️
...b/msal-browser/src/app/IPublicClientApplication.ts 43.75% <ø> (ø)
...ib/msal-browser/src/app/PublicClientApplication.ts 73.80% <ø> (-21.52%) ⬇️
...er/src/broker/nativeBroker/NativeMessageHandler.ts 86.29% <ø> (+0.33%) ⬆️
lib/msal-browser/src/cache/AsyncMemoryStorage.ts 80.76% <ø> (+2.99%) ⬆️
lib/msal-browser/src/cache/BrowserCacheManager.ts 90.18% <ø> (-1.54%) ⬇️
lib/msal-browser/src/cache/BrowserStorage.ts 87.50% <ø> (-3.41%) ⬇️
lib/msal-browser/src/cache/CryptoKeyStore.ts 80.00% <ø> (-3.34%) ⬇️
lib/msal-browser/src/cache/DatabaseStorage.ts 34.00% <ø> (-4.54%) ⬇️
lib/msal-browser/src/cache/MemoryStorage.ts 100.00% <ø> (ø)
... and 72 more

... and 161 files with indirect coverage changes

lib/msal-common/src/authority/Authority.ts Outdated Show resolved Hide resolved
…ntication-library-for-js into metadata-sources
@hectormmg hectormmg merged commit 024f979 into dev Jul 12, 2023
41 of 43 checks passed
@hectormmg hectormmg deleted the metadata-sources branch July 12, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants