-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritize hardcoded metadata over network-sourced metadata #6231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hectormmg
commented
Jul 11, 2023
•
edited
Loading
edited
- Fixes a bug where hardcoded metadata for Cloud Instance Discovery was incorrectly built and therefore never worked
- Promotes hardcoded Cloud Instance Discovery metadata over cached and network metadata sources
- Fixes a bug where azure region update method mutates the existing metadata object instead of returning a new object causing MSAL to prepend azure region cumulatively
- Promotes hardcoded Endpoint metadata over cached and network metadata sources
…tize it over network cloud metadata call
…metadata from hardcoded values
github-actions
bot
added
documentation
Related to documentation.
msal-node
Related to msal-node package
msal-browser
Related to msal-browser package
labels
Jul 12, 2023
Codecov Report
|
hectormmg
requested review from
sameerag,
tnorling,
peterzenz,
jennyf19,
jmprieur,
bgavrilMS,
Robbie-Microsoft,
jo-arroyo and
konstantin-msft
as code owners
July 12, 2023 05:13
konstantin-msft
approved these changes
Jul 12, 2023
peterzenz
approved these changes
Jul 12, 2023
tnorling
approved these changes
Jul 12, 2023
…ntication-library-for-js into metadata-sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Related to documentation.
msal-browser
Related to msal-browser package
msal-common
Related to msal-common package
msal-node
Related to msal-node package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.