Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Facebook sample app #6220

Merged
merged 11 commits into from
Jul 21, 2023
Merged

Adding Facebook sample app #6220

merged 11 commits into from
Jul 21, 2023

Conversation

shylasummers
Copy link
Contributor

@shylasummers shylasummers commented Jul 6, 2023 •
edited
Loading

Adds a sample app using Facebook as an IDP to show how to use OIDCOptions and how to manually pass in endpoints.

Note: this must be merged with or after #6219, because it relies on the OIDCOptions parameter.

@github-actions github-actions bot added the samples Related to the samples apps for the library. label Jul 6, 2023
tnorling
tnorling reviewed Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a README that talks a little bit about the sample - what's different, what's supported, what's not, links to the Facebook app registration docs, etc.

samples/msal-browser-samples/VanillaJSTestApp2.0/app/facebook-sample/authConfig.js Outdated Show resolved Hide resolved
samples/msal-browser-samples/VanillaJSTestApp2.0/app/facebook-sample/authConfig.js Outdated Show resolved Hide resolved
samples/msal-browser-samples/VanillaJSTestApp2.0/app/facebook-sample/authConfig.js Show resolved Hide resolved
@github-actions github-actions bot added the documentation Related to documentation. label Jul 13, 2023
hectormmg
hectormmg approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@hectormmg hectormmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments but overall great!

samples/msal-browser-samples/VanillaJSTestApp2.0/app/facebook-sample/Readme.md Outdated Show resolved Hide resolved
tnorling
tnorling approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

samples/msal-browser-samples/VanillaJSTestApp2.0/app/facebook-sample/Readme.md Outdated Show resolved Hide resolved
@shylasummers shylasummers merged commit c4b8a98 into dev Jul 21, 2023
20 checks passed
@shylasummers shylasummers deleted the facebook-sample branch July 21, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectormmg hectormmg hectormmg approved these changes

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@peterzenz peterzenz peterzenz approved these changes

@derisen derisen Awaiting requested review from derisen

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shylasummers @hectormmg @tnorling @sameerag @peterzenz