Custom-INetworkModule-and-Network-Tracing sample now supports an axios HttpClient as well as requests running on an express server. #5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient. Additionally, it now supports requests running on an express server.
Robbie-Microsoft
requested review from
derisen,
sameerag,
tnorling,
hectormmg,
peterzenz,
jennyf19,
jmprieur and
bgavrilMS
as code owners
github-actions
bot
added
documentation
bgavrilMS
reviewed
Feb 7, 2023
| @@ -53,7 +53,17 @@ class NetworkUtils { | |||
| /** | |||
| * This class implements the API for network requests. | |||
| */ | |||
| export class HttpClient implements INetworkModule { | |||
| export class HttpClientCurrent implements INetworkModule { | |||
There was a problem hiding this comment.
naming? Maybe AxiosHttpClient ?
There was a problem hiding this comment.
Maybe HttpClientNative would be more apt?
bgavrilMS
approved these changes
Feb 7, 2023
derisen
reviewed
Feb 7, 2023
samples/msal-node-samples/custom-INetworkModule-and-network-tracing/express.ts
Outdated
Show resolved
Hide resolved
derisen
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sample has been updated to help debug issues in GitHub Issue 4879 - one user is having difficulties with ConfidentialClient in conjunction with an express server. There are two ways to run the sample now: one is as-is, the other via an express server.
Additionally, in order to prepare for potentially adding axios functionality back to msal-node's HttpClient in the case where the developer isn't using a proxyUrl, a HttpClientAxios was added to this sample to give the developer the option to use as a networkClient instead of the current functionality. The developer now has the option to use either networkClient (or neither) in this sample.