Skip to content

Commit

Permalink
Add missing param to PCA.initialize (#7194)
Browse files Browse the repository at this point in the history
- Add missing param to PCA.initialize
  • Loading branch information
konstantin-msft authored Jul 10, 2024
1 parent 1a15eb9 commit b07a985
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Add missing param to PCA.initialize #7194",
"packageName": "@azure/msal-browser",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion lib/msal-browser/apiReview/msal-browser.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,7 @@ export interface IPublicClientApplication {
// (undocumented)
hydrateCache(result: AuthenticationResult, request: SilentRequest | SsoSilentRequest | RedirectRequest | PopupRequest): Promise<void>;
// (undocumented)
initialize(): Promise<void>;
initialize(request?: InitializeApplicationRequest): Promise<void>;
// (undocumented)
initializeWrapperLibrary(sku: WrapperSKU, version: string): void;
// (undocumented)
Expand Down
4 changes: 3 additions & 1 deletion lib/msal-browser/src/app/IPublicClientApplication.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ import { BrowserConfiguration } from "../config/Configuration";
import { AuthenticationResult } from "../response/AuthenticationResult";
import { EventCallbackFunction } from "../event/EventMessage";
import { ClearCacheRequest } from "../request/ClearCacheRequest";
import { InitializeApplicationRequest } from "../request/InitializeApplicationRequest";

export interface IPublicClientApplication {
initialize(): Promise<void>;
// TODO: Make request mandatory in the next major version?
initialize(request?: InitializeApplicationRequest): Promise<void>;
acquireTokenPopup(request: PopupRequest): Promise<AuthenticationResult>;
acquireTokenRedirect(request: RedirectRequest): Promise<void>;
acquireTokenSilent(
Expand Down

0 comments on commit b07a985

Please sign in to comment.