Merge branch 'dev' into load_user_defined_cache_in_memory

.github/policies/resourceManagement.yml

@@ -0,0 +1,232 @@
+id: 
+name: GitOps.PullRequestIssueManagement
+description: GitOps.PullRequestIssueManagement primitive
+owner: 
+resource: repository
+disabled: false
+where: 
+configuration:
+  resourceManagementConfiguration:
+    scheduledSearches:
+    - description: 
+      frequencies:
+      - hourly:
+          hour: 12
+      filters:
+      - isOpen
+      - hasLabel:
+          label: question
+      - hasLabel:
+          label: 'Needs: Author Feedback'
+      - noActivitySince:
+          days: 5
+      - isIssue
+      - isNotLabeledWith:
+          label: no-issue-activity
+      actions:
+      - addReply:
+          reply: '@${issueAuthor} This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for **5 days**. If your issue has been resolved please let us know by closing the issue. If your issue has **not** been resolved please leave a comment to keep this open. It will be closed automatically in **7 days** if it remains stale.'
+      - addLabel:
+          label: no-issue-activity
+    - description: 
+      frequencies:
+      - hourly:
+          hour: 12
+      filters:
+      - isOpen
+      - hasLabel:
+          label: no-issue-activity
+      - noActivitySince:
+          days: 7
+      - isIssue
+      actions:
+      - closeIssue
+    - description: 
+      frequencies:
+      - hourly:
+          hour: 12
+      filters:
+      - isOpen
+      - isIssue
+      - hasLabel:
+          label: 'Needs: Attention :wave:'
+      - noActivitySince:
+          days: 5
+      actions:
+      - addReply:
+          reply: This issue requires attention from the MSAL.js team and has not seen activity in **5 days**. ${assignees} please follow up.
+    - description: 
+      frequencies:
+      - weekday:
+          day: Monday
+          time: 8:0
+      filters:
+      - isOpen
+      - isNotDraftPullRequest
+      - isPullRequest
+      - noActivitySince:
+          days: 7
+      - isNotLabeledWith:
+          label: 'Needs: Attention :wave:'
+      actions:
+      - addReply:
+          reply: >-
+            Reminder: The next release is scheduled for next week and this PR appears to be stale :( 
+
+
+            If changes have been requested please address feedback. 
+
+            If this PR is still a work in progress please mark as draft.
+      - addLabel:
+          label: 'Needs: Attention :wave:'
+    eventResponderTasks:
+    - if:
+      - payloadType: Issues
+      - or:
+        - labelAdded:
+            label: bug
+        - labelAdded:
+            label: p1
+        - labelAdded:
+            label: p2
+        - labelAdded:
+            label: enhancement
+        - labelAdded:
+            label: feature
+      then:
+      - removeLabel:
+          label: bug-unconfirmed
+      - removeLabel:
+          label: question
+      - removeLabel:
+          label: answered
+      - removeLabel:
+          label: no-issue-activity
+      - removeLabel:
+          label: 'Needs: Attention :wave:'
+      - removeLabel:
+          label: 'Needs: Author Feedback'
+      - removeLabel:
+          label: feature-unconfirmed
+      description: 
+    - if:
+      - payloadType: Issues
+      - isAction:
+          action: Closed
+      then:
+      - removeLabel:
+          label: 'Needs: Attention :wave:'
+      - removeLabel:
+          label: 'Needs: Author Feedback'
+      description: 
+    - if:
+      - payloadType: Issues
+      - isOpen
+      - labelAdded:
+          label: 'Needs: Author Feedback'
+      then:
+      - removeLabel:
+          label: 'Needs: Attention :wave:'
+      description: 
+    - if:
+      - payloadType: Issues
+      - isOpen
+      - labelAdded:
+          label: 'Needs: Attention :wave:'
+      then:
+      - removeLabel:
+          label: 'Needs: Author Feedback'
+      description: 
+    - if:
+      - payloadType: Pull_Request
+      - isAction:
+          action: Opened
+      - isActivitySender:
+          user: dependabot[bot]
+          issueAuthor: False
+      then:
+      - approvePullRequest:
+          comment: ''
+      description: 
+    - if:
+      - payloadType: Issues
+      - hasLabel:
+          label: question
+      - isAction:
+          action: Opened
+      then:
+      - addLabel:
+          label: 'Needs: Attention :wave:'
+      description: 
+    - if:
+      - payloadType: Pull_Request
+      - isAction:
+          action: Opened
+      - not:
+          activitySenderHasAssociation:
+            association: Member
+      - not:
+          isActivitySender:
+            user: github-actions[bot]
+            issueAuthor: False
+      then:
+      - assignIcmUsers:
+          teamId: 80279
+          primary: True
+          secondary: False
+      - assignIcmUsers:
+          teamId: 80279
+          primary: False
+          secondary: True
+      description: 
+    - if:
+      - payloadType: Pull_Request
+      - hasLabel:
+          label: 'Needs: Attention :wave:'
+      - or:
+        - isAction:
+            action: Null
+        - isAction:
+            action: Synchronize
+        - isAction:
+            action: Closed
+      then:
+      - removeLabel:
+          label: 'Needs: Attention :wave:'
+      description: 
+    - if:
+      - payloadType: Pull_Request_Review
+      - hasLabel:
+          label: 'Needs: Attention :wave:'
+      then:
+      - removeLabel:
+          label: 'Needs: Attention :wave:'
+      description: 
+    - if:
+      - payloadType: Issues
+      - not: isAssignedToSomeone
+      - isAction:
+          action: Labeled
+      - hasLabel:
+          label: public-client
+      then:
+      - assignIcmUsers:
+          teamId: 80279
+          primary: True
+          secondary: False
+      description: 
+    - if:
+      - payloadType: Issues
+      - not: isAssignedToSomeone
+      - isAction:
+          action: Labeled
+      - hasLabel:
+          label: confidential-client
+      then:
+      - assignIcmUsers:
+          teamId: 80279
+          primary: True
+          secondary: False
+      description: 
+onFailure: 
+onSuccess: 

.github/workflows/beachball-bump.yml

@@ -34,9 +34,11 @@ jobs:
       # Install node_modules
       - name: Use Node.js
         uses: actions/setup-node@v3
+        with:
+          node-version: 18
 
       - name: Install beachball
-        run: npm ci
+        run: npm ci --workspaces=false
 
       # Beachball bump
       - name: bump package versions

.github/workflows/beachball-check.yml

@@ -41,10 +41,12 @@ jobs:
             - name: Use Node.js
               if: ${{ steps.filter.outputs.lib == 'true' }}
               uses: actions/setup-node@v3
+              with:
+                node-version: 18
 
             - name: Install beachball
               if: ${{ steps.filter.outputs.lib == 'true' }}
-              run: npm ci
+              run: npm ci --workspaces=false
 
             - name: Run Beachball Check command
               if: ${{ steps.filter.outputs.lib == 'true' }}

.github/workflows/build-test-merge-group.yml

@@ -48,8 +48,6 @@ jobs:
 
     - name: Clean Install
       if: steps.cache.outputs.cache-hit != 'true'
-      env:
-        RUNNING_NODE_CI: 1
       run: npm ci
 
     - name: Build packages
@@ -79,8 +77,6 @@ jobs:
       uses: actions/setup-node@v3
 
     - name: Clean Install
-      env:
-        RUNNING_NODE_CI: 1
       run: npm ci
 
     - name: Build packages

.github/workflows/ci-template.yml

@@ -34,22 +34,10 @@ jobs:
       uses: actions/setup-node@v3
       with:
         node-version: 20
+        cache: 'npm'
 
-    - name: Restore node_modules
-      uses: actions/cache@v3
-      id: cache
-      with:
-        path: |
-          node_modules
-          lib/*/node_modules
-          extensions/*/node_modules
-        key: ${{ runner.os }}-${{ hashFiles('package-lock.json', 'lib/*/package-lock.json', 'extensions/*/package-lock.json') }}
-
-    - name: Clean Install
-      if: steps.cache.outputs.cache-hit != 'true'
-      env:
-        RUNNING_NODE_CI: 1
-      run: npm ci
+    - name: Install Dependencies
+      run: npm ci --workspace=${{ inputs.path }}/${{ inputs.lib-name }} --include-workspace-root
 
     - name: Upload npm logs
       uses: actions/upload-artifact@v3

.github/workflows/metadata-check.yml

@@ -25,21 +25,12 @@ jobs:
 
     - name: Use Node.js
       uses: actions/setup-node@v3
-
-    - name: Restore node_modules for libs
-      uses: actions/cache@v3
-      id: lib-cache
       with:
-        path: |
-          node_modules
-          lib/*/node_modules
-        key: ${{ runner.os }}-${{ hashFiles('package-lock.json', 'lib/*/package-lock.json') }}
+        node-version: 18
+        cache: 'npm'
 
     - name: Clean Install
-      if: steps.lib-cache.outputs.cache-hit != 'true'
-      env:
-        RUNNING_NODE_CI: 1
-      run: npm ci
+      run: npm ci --workspace=@azure/msal-common
 
     - name: Check metadata
       working-directory: lib/msal-common

.github/workflows/msal-angular-e2e.yml

@@ -47,27 +47,16 @@ jobs:
     - name: Use Node.js
       uses: actions/setup-node@v3
       with:
-          node-version: 16
+          node-version: 18
+          cache: 'npm'
 
     - name: Clean Install
-      env:
-        RUNNING_NODE_CI: 1
-      run: npm ci
+      run: npm ci --workspace=samples/msal-angular-v3-samples/${{matrix.sample}}
 
     - name: Build packages
       working-directory: lib/msal-angular
       run: npm run build:all
 
-    - name: Install Test Tools
-      working-directory: samples/e2eTestUtils
-      run: npm install
-
-    - name: Install ${{ matrix.sample }}
-      working-directory: samples/msal-angular-v3-samples/${{ matrix.sample }}
-      run: |
-        npm run install:local
-        npm install
-
     - name: Build ${{ matrix.sample }}
       working-directory: samples/msal-angular-v3-samples/${{ matrix.sample }}
       run: npm run build