Changed consent handler to find element by name instead of ID (#4897)

Enabled InteractiveConsentPromptAsync test and change element search from id to name
AzureAD · Aug 22, 2024 · c7eb345 · c7eb345
1 parent 5ff5d21
commit c7eb345
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/tests/Microsoft.Identity.Test.Integration.netcore/Infrastructure/SeleniumExtensions.cs b/tests/Microsoft.Identity.Test.Integration.netcore/Infrastructure/SeleniumExtensions.cs
@@ -189,7 +189,7 @@ public static void PerformLogin(this IWebDriver driver, LabUser user, Prompt pro
 
             HandlePrompt(driver, "otherTile");
             EnterUsername(driver, user, withLoginHint, adfsOnly, fields);
-            HandlePrompt(driver, CoreUiTestConstants.NextButton);
+            HandlePrompt(driver, CoreUiTestConstants.WebSubmitId);
             EnterPassword(driver, user, fields);
 
             HandleConsent(driver, user, fields, prompt);
@@ -251,7 +251,7 @@ private static void HandleConsent(IWebDriver driver, LabUser user, UserInformati
             if (prompt == Prompt.Consent)
             {
                 Trace.WriteLine("Consenting...");
-                driver.WaitForElementToBeVisibleAndEnabled(By.Id(fields.AADSignInButtonId)).Click();
+                driver.WaitForElementToBeVisibleAndEnabled(By.Name(fields.AADSignInButtonId)).Click();
             }
         }
 

diff --git a/.../Microsoft.Identity.Test.Integration.netcore/SeleniumTests/InteractiveFlowTests.NetFwk.cs b/.../Microsoft.Identity.Test.Integration.netcore/SeleniumTests/InteractiveFlowTests.NetFwk.cs
@@ -77,8 +77,6 @@ public async Task Interactive_AdfsV4_FederatedAsync()
         }
 
         [RunOn(TargetFrameworks.NetCore)]
-        // See https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/4879
-        [Ignore]
         public async Task InteractiveConsentPromptAsync()
         {
             var labResponse = await LabUserHelper.GetDefaultUserAsync().ConfigureAwait(false);