Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: refactor to maintain policy state in-memory #33

Closed
wants to merge 12 commits into from
Closed

enhancement: refactor to maintain policy state in-memory #33

wants to merge 12 commits into from

Conversation

cmaclaughlin
Copy link
Contributor

Re: #25

The capacity scheduling plugin was used for frame of reference. A collection of policy information is kept in-memory on the PlacementPolicyManager. Instead of annotations, the policy info in the collection includes 2 sets:

  • all pods that qualify for / fall under the policy
  • all pods assigned to nodes in accordance with the policy ("managed by")

An event handler was attached to the pod informer so pod deletion can trigger updating the in-memory version of the policy accordingly. Additionally, the custom info object is included in the state object added to cycle state as a part of PreFilter and PreScore stages so that Filter and Score stages have access to it as well.

@cmaclaughlin cmaclaughlin changed the title Refactor to maintain policy state in-memory enhancement: refactor to maintain policy state in-memory Jan 13, 2022
@cmaclaughlin cmaclaughlin marked this pull request as ready for review January 13, 2022 21:24
@helayoty helayoty linked an issue Jan 13, 2022 that may be closed by this pull request
@helayoty helayoty self-requested a review January 14, 2022 00:15
@helayoty helayoty added the enhancement New feature or request label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to scheduler plugin logic
2 participants