This repository has been archived by the owner on Jul 6, 2022. It is now read-only.
Allow deployment on kubernetes 1.16+ #738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapoz-tech
requested review from
krancour,
norshtein and
zhongyi-zhang
as code owners
|
|
|
@norshtein would be good to take a look at this ^^ FYI we had the same issue, and also had to update the redis version this chart depends on: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I discovered an issue trying to deploy OSBA on newer Kubernetes releases (e.g. 1.16+), due to the promoted Deployment object API. I made deployment apiVersion parametric based on kubernetes version, and changed the predefined image tag in values.yaml