[main] Inherit VERSION for IIS build in ARM64 Mariner
#6587
Conversation
onalante-msft
changed the title
VERSION for IIS build in ARM64 Mariner
onalante-msft
force-pushed
the
mariner-arm-iis-version
branch
from
8a83633
to
ab2e70c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Awaiting #6586. |
|
please remove all references to $packageVersion. there is still one in line 321 |
onalante-msft
force-pushed
the
mariner-arm-iis-version
branch
from
ab2e70c
to
34aba3d
Compare
onalante-msft
force-pushed
the
mariner-arm-iis-version
branch
from
34aba3d
to
7d4af68
Compare
| sudo docker run --rm \ | ||
| -v "$(Build.SourcesDirectory)/iot-identity-service:/src" \ | ||
| -e "ARCH=$PACKAGE_ARCH" \ | ||
| -e "OS=$OS:$OSVERSION" \ | ||
| -e "PACKAGE_VERSION=$packageVersion" \ | ||
| -e "PACKAGE_VERSION=$VERSION" \ |
There was a problem hiding this comment.
Iotedge and Iot-identity-service do not require to have the same version. The best we can do here is probably parse the version from https://github.com/Azure/iot-identity-service/blob/main/.github/workflows/packages.yaml#L68.
Note: The URI is required to be updated if the new branch be created. (i.e. main -> release/1.4).
There was a problem hiding this comment.
Ideally, we would be tagging our release commits (edit: relative to main) so that we could just set VERSION=$(git describe). However, given that we do not do this, the next safest alternative is probably to add a version.txt at the root directory of iot-identity-service as we do for iotedge. Parsing CI files for a version string seems fragile.
There was a problem hiding this comment.
We do tag our release artifacts for a given release branch -- main is not a release branch; hence, no tag.
I like the idea of version.txt for the iot-identity-service repo.
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines