add more edge cases to Query Error parser #2003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview this branch
The backend has shifted how errors are reported a bit. Now, when we get detailed query errors from newer backends, we get a payload that looks like this:
Our current parsing doesn't support this (it's basically added another layer of JSON wrapping the error), so I've added support for it.
NOTE: I'm still working with the query team to get this into a format that doesn't require quite so many hacks to parse, but until then, we kinda have to just chase the weird formatting a bit. I was expecting a change like this to come, and am not expecting another change in format (until, hopefully, we can get errors reported as a top-level JSON property).