Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ptn/azd/aks parameter #3589

Merged
merged 18 commits into from
Oct 25, 2024
Merged

Conversation

Menghua1
Copy link
Member

@Menghua1 Menghua1 commented Oct 18, 2024

Description

Updated some aks parameters.

Pipeline Reference

Pipeline
avm.ptn.azd.aks

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio and @AlexanderSehr for notification.

@Menghua1 Menghua1 requested review from a team as code owners October 18, 2024 07:43
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 18, 2024
@Menghua1 Menghua1 changed the title Update ptn/azd/aks parameter fix: Update ptn/azd/aks parameter Oct 18, 2024
@Menghua1
Copy link
Member Author

Menghua1 commented Oct 18, 2024

@jongio When updating PR#3976, it was found that ptn/azd/aks was missing some parameters when migrating, so I opened this PR to modify the parameters of ptn/azd/aks. Please review it, thank you.

update systemPoolConfig and agentPoolConfig parameter

update systemPoolConfig and agentPoolConfig parameter

update systemPoolConfig and agentPoolConfig parameter

update systemPoolConfig and agentPoolConfig parameter
@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Oct 22, 2024

Will leave the final module review to the owner @jongio :). Thanks for putting in all the work @Menghua1 💪

update systemPoolConfig and agentPoolConfig

update systemPoolConfig and agentPoolConfig

update systemPoolConfig and agentPoolConfig
@v-xuto
Copy link
Member

v-xuto commented Oct 23, 2024

@jongio Could you help review this PR? It blocks the progress of migration to avm.

@Menghua1
Copy link
Member Author

Menghua1 commented Oct 25, 2024

@AlexanderSehr Could you please review this PR? If there is no issue, please approve it.

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Oct 25, 2024

@AlexanderSehr Could you please review this PR? If there is no issue, please approve it.

I can - but as it should be up to the module owner, let's check with @jongio whether there is a reason the PR was not merged. He should have the permissions. As a maintainer we don't have to approve & merge PRs once the module's are in. That's the point of the ownership 😉

@v-xuto
Copy link
Member

v-xuto commented Oct 25, 2024

@jongio Could you help merge this PR? Thanks a lot.

@AlexanderSehr
Copy link
Contributor

@jongio Could you help merge this PR? Thanks a lot.

Hey @v-xuto I also reached out via teams. I'm sure we get the PR in in no time

@jongio jongio merged commit 1e763a5 into Azure:main Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants