-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a different message when writing tags fails due to permissions issues, add test #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
August 27, 2024 02:36
tanyasethi-msft
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the pipelines seem to fail because of the MaxStorageAccountsCountPerSubscriptionExceeded, waiting for the cleanup, along with a string linter error which might need attention.
Resolves #2798 |
vibhansa-msft
approved these changes
Oct 14, 2024
gapra-msft
reviewed
Oct 14, 2024
gapra-msft
reviewed
Oct 14, 2024
gapra-msft
reviewed
Oct 21, 2024
Co-authored-by: Gauri Lamunion <[email protected]>
gapra-msft
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the failure point includes data about tags, we now treat that as a failure writing tags, and log about needing tags permissions (per stgexp's request).
A single test case covers Upload & S2S cases for writing tags, as well as different blob types, hitting all code paths.