Tables cleanup work #6181
Tables cleanup work #6181
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run cpp - tables |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/tables/azure-data-tables/samples/tables_entity_operations.cpp
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/samples/tables_getting_started.cpp
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/inc/azure/data/tables/table_client.hpp
Outdated
Show resolved
Hide resolved
|
/azp run cpp - tables |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run cpp - tables - ci |
|
Azure Pipelines failed to run 1 pipeline(s). |
sdk/tables/azure-data-tables/inc/azure/data/tables/table_client.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Kolesnyk <[email protected]>
|
/azp run cpp - tables |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Anton Kolesnyk <[email protected]>
Co-authored-by: Anton Kolesnyk <[email protected]>
|
/azp run cpp - tables |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| * @param context for canceling long running operations. | ||
| * @return Get access policy result. | ||
| */ | ||
| Response<Models::TableAccessPolicy> GetAccessPolicy(Core::Context const& context = {}); |
There was a problem hiding this comment.
Why are we removing Get/Set AccessPolicy?
There was a problem hiding this comment.
Because credentials, they do not work with either token or SAS, connection string only, which we removed in this PR also. If we want these APIs to be there then we need those creds, which are not allowed anymore by SFI. so chicken <-> egg
sdk/tables/azure-data-tables/inc/azure/data/tables/account_sas_builder.hpp
Show resolved
Hide resolved
| auto tableServiceClient = Azure::Data::Tables::TableServiceClient( | ||
| "https://" + accountName + ".table.core.windows.net/", credential); | ||
| auto tableClient = Azure::Data::Tables::TableClient( | ||
| "https://" + accountName + ".table.core.windows.net/", TableName, credential); |
There was a problem hiding this comment.
Is the URL always going to be in the table.core.windows.net domain? Or is there a better way of figuring out the URL for the service?
For other services, they often take an instance URL as an environment variable rather than constructing the service URL - that way it works for sovereign clouds, etc.
| int main() | ||
| { | ||
| auto tableServiceClient = TableServiceClient::CreateFromConnectionString(GetConnectionString()); | ||
| auto tableClient = TableClient::CreateFromConnectionString(GetConnectionString(), TableName); | ||
| const std::string accountName{std::getenv("ACCOUNT_NAME")}; |
There was a problem hiding this comment.
This doesn't appear to be an "account" name, instead it appears to be a service instance name -to me, an "account" is associated with an entra ID and not an instance.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.