Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP Disk AMBA review by PM Alec Becker #228

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

pinyuko
Copy link

@pinyuko pinyuko commented May 30, 2024

Overview/Summary

I've asked Disk Metrics PM Alec Becker to review Disk related AMBA.

This PR fixes/adds/changes/removes

  1. Remove "OS Disk Bandwidth Consumed Percentage >= 90" since it's duplicated.
  2. Change "Data Disk IOPS Consumed Percentage > 95" to be threshold 90.
  3. In progress: < Not yet applied> Remove static number alerts, customer should use the percentage ones. E.g. "Available Memory Bytes < 500000000", "Linux OS High memory usage MB > 5000", "Linux OS High Disk Read MB per Sec > 10"
  4. Remove Latency related

Breaking Changes

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@pinyuko
Copy link
Author

pinyuko commented May 30, 2024

Hi @humblejay , I'm Penny Ko in MSFT. I would like to discuss the details with you when PM Alec Becker confirmed about the details of the static and latency metrics. I couldn't find your name in MSFT, please kindly reach out to me through Teams or let me know how to contact you within MSFT. Thanks!

@humblejay
Copy link
Contributor

humblejay commented May 31, 2024 via email

@JoeyBarnes JoeyBarnes added Pattern: SAP Issues / PR's related to the SAP Pattern labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: SAP Issues / PR's related to the SAP Pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants