Reapply "Switch from create-react-app to vite (#7808)" with fixes #7828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joechung-msft
requested review from
ehamai,
takyyon,
shimedh,
refortie and
andimarc
joechung-msft
force-pushed
the
joechung/vite-take-two
branch
from
c2fbf99
to
a413a99
Compare
joechung-msft
force-pushed
the
joechung/vite-take-two
branch
from
a413a99
to
94eb533
Compare
joechung-msft
changed the title
shimedh
approved these changes
Sep 19, 2024
This reverts commit a1dfb00. Additional changes: - Remove `basePlugin` and customize base configuration: - Set base to `/` instead of `./`. - Remove `buildPathPlugin` and customize build configuration: - Empty `build` folder before each build to ensure clean builds. - Rename `assets` to `static` to align with what AFD expects. - Rename `dist` to `build`.
joechung-msft
force-pushed
the
joechung/vite-take-two
branch
from
94eb533
to
28cb013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a1dfb00.
Changes:
Remove
basePluginand customize base configuration:/instead of./Remove
buildPathPluginand customize build configuration:buildfolder before each build to ensure clean buildsassetstostaticto align with what AFD expectsdisttobuild