Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.DurableTask.Grpc to latest version #2919

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

cgillum
Copy link
Collaborator

@cgillum cgillum commented Sep 28, 2024

This change updates the Microsoft.DurableTask.Grpc package to the latest version (1.3.0). This is important because there was a breaking change in an earlier version of this package, making the extension incompatible with certain backend extensions. This change will fix the incompatibility.

This PR also updates the versions in the WebJobs.Extensions.DurableTask and Functions.Worker.Extensions.DurableTask projects.

Issue describing the changes in this PR

Without this fix, it's possible for certain backends to run into a MissingMethodException on set_CorrelationData since that property was removed in a previous version of the Microsoft.DurableTask.Grpc package. This PR removes the dependency on that missing property and replaces it with the modern (TraceV2) variant. This only impacts .NET Isolated and Java. There's no impact to other stacks.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v3.x branch.
    • Otherwise: This change only applies to Durable Functions v2.x and will not be merged to branch v3.x.

Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question

Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked w/ @bachuv - Distributed Tracing V1 is only supported in .NET in-proc so the other stacks should not be affected

@cgillum cgillum merged commit 1163944 into dev Oct 1, 2024
14 checks passed
@cgillum cgillum deleted the cgillum/update-protobuf branch October 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants