Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial changes for extension channel #2812

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Initial changes for extension channel #2812

wants to merge 1 commit into from

Conversation

jviau
Copy link
Contributor

@jviau jviau commented May 9, 2024

Draft PR to demonstrate how durable would switch to using the existing gRPC channel provided by the functions worker. This is a very old branch and will have many conflicts / out of date changes that will need to be updated.

This change does move and more and more towards specializing the WebJobs extension for out-of-proc workers. This makes me wonder if there is value in splitting the extension: one for in-proc, one for all others (and common assemblies as needed).

Known Issues / Remaining Work

@davidmrdavid
Copy link
Contributor

I worry the .NET6 requirement might be a showstopper, I remember it being so when trying to make similar changes for Java, unless I'm misremembering.

@jviau
Copy link
Contributor Author

jviau commented May 10, 2024

I worry the .NET6 requirement might be a showstopper, I remember it being so when trying to make similar changes for Java, unless I'm misremembering.

If we do this as part of the major version rev then I think it is possible to make it work but will be challenging. Bundles is the biggest question to me: can they support .net6.0 packages?

@cgillum
Copy link
Collaborator

cgillum commented May 10, 2024

Bundles v4 supports .NET Core 3.1, so we can't take a dependency on .NET 6+ unless there's also a new major bundles version release.

@jviau
Copy link
Contributor Author

jviau commented May 10, 2024

Requesting bundles support .NET6 is a reasonable ask. .netcoreapp3.1 is a well out of support, so it is problematic for extensions to be stuck on it due to bundles.

Opened an issue for that support: Azure/azure-functions-extension-bundles#402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants