Fix handling of entity operation errors for isolated entities #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is not properly handling failing entity operation batches. Specifically, for failing batches, it was failing all operations indiscriminately, instead of processing the failure details of each operation in the batch and sending them back to the orchestration caller.
This PR fixes the problem by propagating the results of the batch back to the DurableTask middleware pipeline, even if the function failed.
I think this bug could have been caught if the entity tests #2612 were run in CI, as opposed to having to run them manually (I remember these tests all passing last year but they are failing now which alerted me to this problem).
Pull request checklist
release_notes.md