[For private package] Add Entity Telemetry in exchange of EventGridNotification logs #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianburckhardt
requested changes
Sep 18, 2023
| @@ -159,7 +159,7 @@ private EtwEventSource() | |||
| this.WriteEvent(209, TaskHub, AppName, SlotName, FunctionName, InstanceId, Reason, FunctionType, ExtensionVersion, IsReplay); | |||
| } | |||
|
|
|||
| [Event(210, Level = EventLevel.Informational, Version = 3)] | |||
There was a problem hiding this comment.
I would set version to 5 here since the previous version of event 233 was 4.
| } | ||
|
|
||
| [Event(211, Level = EventLevel.Error, Version = 3)] |
There was a problem hiding this comment.
similarly, use version 5 since previous version of event 234 was 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For private package only. IcM is = 423004777
As per this comment, the EventIds for some of our entity telemetry is not showing up in our telemetry yet.
This draft PR is a hack that swaps the ETW EventIds of EventGridNotifications for the Entity ETW events. That should suffice to let these critical logs surface to our Kusto server for investigation's sake.