Adding bicep script to deploy azure function Dapr extension samples in ACA #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MD Ashique <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 71.97% 72.62% +0.64%
==========================================
Files 51 52 +1
Lines 1017 1041 +24
==========================================
+ Hits 732 756 +24
Misses 285 285 |
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
shubham1172
reviewed
Sep 12, 2023
shubham1172
reviewed
Sep 12, 2023
Co-authored-by: Shubham Sharma <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
shubham1172
reviewed
Sep 19, 2023
shubham1172
reviewed
Sep 19, 2023
Comment on lines
125
to
127
| /* ###################################################################### */ | ||
| // Create Azure EventHub | ||
| /* ###################################################################### */ |
There was a problem hiding this comment.
Can we move other eventHub resources like namespace and auth below this comment block? Same for other services too.
shubham1172
reviewed
Sep 19, 2023
Co-authored-by: Shubham Sharma <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
shubham1172
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.