Adding hosting env check for #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MD Ashique <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 71.97% 72.62% +0.64%
==========================================
Files 51 52 +1
Lines 1017 1041 +24
==========================================
+ Hits 732 756 +24
Misses 285 285
|
shubham1172
reviewed
Aug 18, 2023
Signed-off-by: MD Ashique <[email protected]>
shubham1172
reviewed
Aug 22, 2023
src/Microsoft.Azure.WebJobs.Extensions.Dapr/Utils/EnvironmentExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Dapr/DaprExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes for adding a condition to restrict below hosting environment of azure functions.
Why did we add restricted list instead of allowed list:
Azure Functions Dapr extension is supposed to work on self hosted env as well as in AKS, so having the restricted list helps us achieve this easily, where Dapr extension will still be working in self hosted and AKS env along with ACA.