suppressing CodeQL.SM02196 #3876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
reviewed
Oct 9, 2024
liliankasem
reviewed
Oct 16, 2024
| @@ -121,6 +121,9 @@ internal static async Task<X509Certificate2> CreateCertificateOpenSSL() | |||
| return new X509Certificate2($"{certFileNames}certificate.pfx", DEFAULT_PASSWORD); | |||
| } | |||
|
|
|||
|
|
|||
jviau
reviewed
Oct 17, 2024
| @@ -121,10 +121,9 @@ internal static async Task<X509Certificate2> CreateCertificateOpenSSL() | |||
| return new X509Certificate2($"{certFileNames}certificate.pfx", DEFAULT_PASSWORD); | |||
| } | |||
|
|
|||
| // Suppressing CodeQL warning because this code is only used to validate blob content. Not used to encrypt any secrets | |||
|
|
|||
| // CodeQL [SM02196] intent is to validate blob content. Not used to encrypt any secrets | |||
There was a problem hiding this comment.
This is on the wrong line. It needs to be on same line as using (var md5 = MD5.Create()) or be immediately above it.
// CodeQL [SM02196] intent is to validate blob content. Not used to encrypt any secrets
using (var md5 = MD5.Create())OR
using (var md5 = MD5.Create()) // CodeQL [SM02196] intent is to validate blob content. Not used to encrypt any secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We calculate md5 for a blob before uploading a zip package for run from package. This is validated against the precalculated md5 from blob client on azure to ensure the full zip file got uploaded.
We cannot change this as blob client provides md5 out of the box.