-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure Container Apps API version 2023-04-01-preview on Retirement #3076
Update Azure Container Apps API version 2023-04-01-preview on Retirement #3076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - FWIW we use containerApps@2023-05-02-preview in aspire. Should we be concerned about upgrading that one to a stable one as well?
Would be interesting to see if we can get away with 2023-05-01
, I suppose. I'm not sure what the difference in the preview API version is and if it is something we need. We don't set to many properties on these things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about version for managedEnvironments - otherwise looks good.
templates/common/infra/bicep/core/host/container-apps-environment.bicep
Outdated
Show resolved
Hide resolved
I think Wallace's proposed diffs are correct here - could you please update this and land it with a smoke test of one of the container apps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, @vhvb1989! I think that Wallace's changes are correct.
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: azd-starter-bicepRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/azd-starter-bicep -b pr/3076 View Changes | Compare Changes Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/3076 View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/3076 View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/3076 View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/3076 View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/3076 View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/3076 View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/3076 View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/3076 View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3076 View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3076 View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3076 View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/3076You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/3076 View Changes | Compare Changes |
I am updating everything to use I would consider trying a newer preview to see if that help us with the external ports issues (and some other things). But maybe after aspire preview4 release. |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Starting 6 March 2024, you won’t be able to manage Azure Container Apps using version 2023-04-01-preview of the Azure Resource Manager API.
Updating:
Reviewed this versions to be used across all azure-dev (templates, easy init and Aspire)