-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry notice to azd #2581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions but overall looks good.
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
@savannahostrowski, @Austinauth -- UX change: Here's the telemetry notice being displayed on first run in Cloud Shell. User has to be in Cloud Shell to see the notice. |
No issues on my end, looks good. |
Fixes #2580 |
Adds telemetry notice when running azd in Cloud Shell. This is a point fix. It does not touch the Cloud Shell auth code though there is some common code which could be refactored.
If the first run happens in a JSON output scenario (likely not an interactive scenario), telemetry is disabled,
first-run
file is not created, no telemetry notice is printed (stderr is used for reporting status). Telemetry will stay disabled in this case until a command is run without JSON output (most likely an interactive scenario).@weikanglim -- Want to make sure this is properly disabling telemetry, see changes in
telemetry.go
Fixes #2580