Skip to content

Commit

Permalink
Additional review cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
danieljurek committed Jan 29, 2024
1 parent 706f823 commit 936f2c9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions cli/azd/pkg/auth/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ func (m *Manager) LoginInteractive(
scopes []string,
options *LoginInteractiveOptions) (azcore.TokenCredential, error) {
if scopes == nil {
scopes = m.GetLoginScopes()
scopes = m.LoginScopes()
}
acquireTokenOptions := []public.AcquireInteractiveOption{}
if options == nil {
Expand Down Expand Up @@ -510,7 +510,7 @@ func (m *Manager) LoginInteractive(
func (m *Manager) LoginWithDeviceCode(
ctx context.Context, tenantID string, scopes []string, withOpenUrl WithOpenUrl) (azcore.TokenCredential, error) {
if scopes == nil {
scopes = m.GetLoginScopes()
scopes = m.LoginScopes()
}
options := []public.AcquireByDeviceCodeOption{}
if tenantID != "" {
Expand Down
6 changes: 3 additions & 3 deletions cli/azd/pkg/azapi/deployments.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
"github.com/azure/azure-dev/cli/azd/pkg/account"
"github.com/azure/azure-dev/cli/azd/pkg/azsdk"
"github.com/azure/azure-dev/cli/azd/pkg/azure"
azdCloud "github.com/azure/azure-dev/cli/azd/pkg/cloud"
"github.com/azure/azure-dev/cli/azd/pkg/cloud"
"github.com/azure/azure-dev/cli/azd/pkg/httputil"
)

Expand Down Expand Up @@ -91,13 +91,13 @@ type deployments struct {
credentialProvider account.SubscriptionCredentialProvider
httpClient httputil.HttpClient
userAgent string
cloud *azdCloud.Cloud
cloud *cloud.Cloud
}

func NewDeployments(
credentialProvider account.SubscriptionCredentialProvider,
httpClient httputil.HttpClient,
cloud *azdCloud.Cloud,
cloud *cloud.Cloud,
) Deployments {
return &deployments{
credentialProvider: credentialProvider,
Expand Down
4 changes: 2 additions & 2 deletions cli/azd/pkg/cloud/cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type Config struct {
}

func NewCloud(config *Config) (*Cloud, error) {
if cloud, err := namedCloud(config.Name); err != nil {
if cloud, err := parseCloudName(config.Name); err != nil {
return nil, err
} else {
return cloud, nil
Expand Down Expand Up @@ -79,7 +79,7 @@ func AzureChina() *Cloud {
}
}

func namedCloud(name string) (*Cloud, error) {
func parseCloudName(name string) (*Cloud, error) {
if name == AzurePublicName || name == "" {
return AzurePublic(), nil
} else if name == AzureChinaCloudName {
Expand Down

0 comments on commit 936f2c9

Please sign in to comment.