Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for sbt-based project #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Proposal for sbt-based project #105

wants to merge 3 commits into from

Conversation

jcjimenez
Copy link

@jcjimenez jcjimenez commented Aug 18, 2017

Hi All, this is my proposal for migrating to sbt (#58). You may notice there are some minor differences between the dependencies in the original pom.xml which were done to address problems in Scala version conflicts or eviction warnings like the following:

[warn] There may be incompatibilities among your library dependencies.
[warn] Here are some of the libraries that were evicted:
[warn] 	* com.fasterxml.jackson.module:jackson-module-scala_2.11:2.6.5 -> 2.9.0
[warn] 	* com.twitter:chill_2.11:0.8.0 -> 0.9.2
[warn] 	* org.json4s:json4s-jackson_2.11:3.2.11 -> 3.5.3
[warn] Run 'evicted' to see detailed eviction warnings

Lastly, I had to remove these two calls from one of the tests because those #close() methods aren't present in the 3.2.5 version of hadoop-gremlin (it looks like they are in the current SNAPSHOT, so not sure how those methods were available via the pom.xml project):

        HadoopPools.close();
        KryoShimServiceLoader.close();

Lastly, not sure how to run the test in Travis, so I removed the test task from the .travis.yml =(

@khdang
Copy link
Member

khdang commented Aug 19, 2017

This is awesome. Thanks, @jcjimenez! Let us look into the dependency changes that you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants