-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding stateless CNI support for ACI #3085
base: master
Are you sure you want to change the base?
Conversation
LGTM. we tested this in an integration environment with ACI and it solved the issue we faced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add the details of the special case in the pr description (like the timeline of events and why there is no entry in the cns state by the time we call update endpoint helper)-- I thought the endpoint state is usually populated in updateEndpointState in cns, unless we don't request ips? Is InfraContainerID (in update endpoint state) typically equal to endpointID (in update endpoint helper)?
DOne |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we write UT for this case
802087c
to
8b76b55
Compare
8b76b55
to
a0d5808
Compare
Done |
feat: adding stateless CNI support for ACI>
New entry in CNS statefile will be added for a container upon updateEndpoint request if the entry does not already exist. This covers a special case for ACI.
In ACI the CNS path to allocate IP address and send goalstate is different than CNS IPAM for Cilium and azure-cni for AKS. As a result, the endpoint entry for statefile is not getting create upon IP allocation and this fix will create the whole entry when CNI send updateEndpoint API request to CNS.
Notes: