fix: add default route on customer vnets and provide default route from CNS to CNI #3027
+114
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
force-pushed
the
fixdefaultRouteSwiftv2windows
branch
from
39e5a07
to
ab9e2c7
Compare
tamilmani1989
requested changes
Sep 23, 2024
paulyufan2
force-pushed
the
fixdefaultRouteSwiftv2windows
branch
from
ab9e2c7
to
c0ef702
Compare
paulyufan2
force-pushed
the
fixdefaultRouteSwiftv2windows
branch
from
9fe4da9
to
b14386f
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulyufan2
changed the title
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
requested changes
Sep 26, 2024
| @@ -428,7 +428,7 @@ func (nw *network) newEndpointImplHnsV2(cli apipaClient, epInfo *EndpointInfo) ( | |||
| } | |||
|
|
|||
| // Create the HCN endpoint. | |||
| logger.Info("Creating hcn endpoint", zap.Any("hcnEndpoint", hcnEndpoint), zap.String("computenetwork", hcnEndpoint.HostComputeNetwork)) | |||
| logger.Info("Creating hcn endpoint", zap.Any("hcnEndpoint", hcnEndpoint), zap.String("computenetwork", hcnEndpoint.HostComputeNetwork), zap.Any("routes", hcnEndpoint.Routes)) | |||
There was a problem hiding this comment.
can skip logging routes if hcnendpoint object already logs it.
There was a problem hiding this comment.
zap log does not log Routes field from hcnEndpoint
paulyufan2
force-pushed
the
fixdefaultRouteSwiftv2windows
branch
3 times, most recently
from
24dc6b2
to
43cd9da
Compare
paulyufan2
force-pushed
the
fixdefaultRouteSwiftv2windows
branch
4 times, most recently
from
a14aeff
to
2a7940f
Compare
paulyufan2
force-pushed
the
fixdefaultRouteSwiftv2windows
branch
from
6a020d2
to
9f20666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to fix one issue in swiftv2 Windows scenario:
When a pod is created, the default route is added on infra vnet:
root@swiftv2-pod-3:/# ip route
default via 10.244.2.1 dev eth0 metric 1
It leads to ping a VM IP in the same VNET that cannot work.
There are two issues::
1.CNS does not provide the default route to CNI;
2.CNI should only add the default route to secondary interface customer vnet; on Swiftv2 scenario, skipDefaultRoutes is set to true for infraNIC interface and false for a secondary interface; so if !info.skipDefaultRoutes, then add default route.
Issue Fixed:
Requirements:
Notes: