Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nil was mistakenly being passed to emitMetrics, causing resultType to always fail collection due to the nil backendError provided.
Which issue this PR addresses:
Fixes ARO-10816
What this PR does / why we need it:
The backend error was not being passed to
emitMetrics
,nil
was being provided instead.This caused the resultType to always fail to collect, given that the error was always
nil
.Example of this:
Test plan for issue:
Existing unit tests cover this.
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
The existing unit tests work correctly when the backendErr is provided, with a status code.